Skip to content

fix(widget): allow to leave edit mode#5508

Merged
elzody merged 1 commit intomainfrom
fix/widget_exit_edit
Mar 25, 2026
Merged

fix(widget): allow to leave edit mode#5508
elzody merged 1 commit intomainfrom
fix/widget_exit_edit

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Mar 21, 2026

Fixes: #5458

Screenshots

Before After
image image
image image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits

Fixes: #5458

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- requested a review from emberfiend March 21, 2026 18:18
@mejo- mejo- self-assigned this Mar 21, 2026
@mejo- mejo- requested a review from elzody as a code owner March 21, 2026 18:18
@mejo- mejo- added the bug Something isn't working label Mar 21, 2026
@mejo- mejo- requested a review from juliusknorr as a code owner March 21, 2026 18:18
@mejo- mejo- added the 3. to review Ready to be reviewed label Mar 21, 2026
Copy link
Copy Markdown
Collaborator

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are nice and it works well after trying it out :)

Note: The static analysis failure is unrelated

@elzody
Copy link
Copy Markdown
Collaborator

elzody commented Mar 25, 2026

/backport to stable33 please

@elzody
Copy link
Copy Markdown
Collaborator

elzody commented Mar 25, 2026

/backport to stable32

@elzody elzody merged commit 66bd02f into main Mar 25, 2026
51 of 55 checks passed
@elzody elzody deleted the fix/widget_exit_edit branch March 25, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot exit Edit-Mode of embedded Office file

2 participants